<html>
<head><meta charset="utf-8"><title>triage 2021 01 26 · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html">triage 2021 01 26</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="224044127"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224044127" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224044127">(Jan 26 2021 at 14:15)</a>:</h4>
<p>hey! it's tuesday again, though I have a hard time believing it. last week went by really quickly. <span class="user-mention" data-user-id="224872">@rylev</span> would you be up for a round of triage?</p>



<a name="224044256"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224044256" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224044256">(Jan 26 2021 at 14:16)</a>:</h4>
<p>I might be able to today, but I need to finish what I'm currently working on and I'm not sure how long it will take.</p>



<a name="224045074"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224045074" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224045074">(Jan 26 2021 at 14:22)</a>:</h4>
<p>ok. Let me know if you don't think you'll get to it, I should have some time later tonight in 6 hours or so.</p>



<a name="224045810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224045810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224045810">(Jan 26 2021 at 14:27)</a>:</h4>
<p>Perhaps I can kick it off, and then hand it over to you?</p>



<a name="224045843"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224045843" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224045843">(Jan 26 2021 at 14:27)</a>:</h4>
<p>I'm sure I can carve out 30 minutes at some point...</p>



<a name="224045947"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224045947" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224045947">(Jan 26 2021 at 14:28)</a>:</h4>
<p>yeah for sure, sounds great</p>



<a name="224099164"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224099164" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224099164">(Jan 26 2021 at 20:36)</a>:</h4>
<p>Going to start this now</p>



<a name="224105016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105016">(Jan 26 2021 at 21:19)</a>:</h4>
<p>/me really, seriously starts triaging</p>



<a name="224105070"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105070" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105070">(Jan 26 2021 at 21:19)</a>:</h4>
<p>Interestingly, <a href="https://github.com/rust-lang/rust/pull/80958">https://github.com/rust-lang/rust/pull/80958</a> seems to lead to a perf regression even though it doesn't seem to touch much code...</p>



<a name="224105185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105185">(Jan 26 2021 at 21:20)</a>:</h4>
<p>expand_crate and hir_lowering seem to be effected here: <a href="https://perf.rust-lang.org/detailed-query.html?commit=339e19697a39a78f4d669c217b7d21109215de41&amp;base_commit=57a71ac0e17e4f7070b090ab7bdc5474d8e37ecc&amp;benchmark=regex-check&amp;run_name=incr-patched:%20Job">https://perf.rust-lang.org/detailed-query.html?commit=339e19697a39a78f4d669c217b7d21109215de41&amp;base_commit=57a71ac0e17e4f7070b090ab7bdc5474d8e37ecc&amp;benchmark=regex-check&amp;run_name=incr-patched:%20Job</a></p>



<a name="224105191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105191">(Jan 26 2021 at 21:20)</a>:</h4>
<p>It may be that the PR causes lots of lints to fire in our (relatively old) crates</p>



<a name="224105220"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105220" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105220">(Jan 26 2021 at 21:20)</a>:</h4>
<p>I had the same thought</p>



<a name="224105238"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105238" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105238">(Jan 26 2021 at 21:20)</a>:</h4>
<p>those particular passes suggest attributes rather than lowering though, hm</p>



<a name="224105281"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105281" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105281">(Jan 26 2021 at 21:21)</a>:</h4>
<p>I would ask on PR, though the author is unlikely to know - we should note as future work nag</p>



<a name="224105328"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105328" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105328">(Jan 26 2021 at 21:21)</a>:</h4>
<p>Though it does say that the lints are only triggered when the user opts in</p>



<a name="224105432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105432">(Jan 26 2021 at 21:22)</a>:</h4>
<p>hm</p>



<a name="224105447"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105447" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105447">(Jan 26 2021 at 21:22)</a>:</h4>
<p>maybe just more attributes to sort through? seems surprising</p>



<a name="224105464"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224105464" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224105464">(Jan 26 2021 at 21:22)</a>:</h4>
<p>Yea. I'll make a note and ask</p>



<a name="224107484"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224107484" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224107484">(Jan 26 2021 at 21:38)</a>:</h4>
<p>Rollup with a regression <a href="https://github.com/rust-lang/rust/pull/81240">https://github.com/rust-lang/rust/pull/81240</a>. My bet on the PR that is to blame is: <a href="https://github.com/rust-lang/rust/pull/81178">https://github.com/rust-lang/rust/pull/81178</a></p>



<a name="224107896"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224107896" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224107896">(Jan 26 2021 at 21:41)</a>:</h4>
<p>:-( Perf was neutral at first on this PR but then changes made the perf worse (<a href="https://github.com/rust-lang/rust/pull/80919">https://github.com/rust-lang/rust/pull/80919</a>) Not sure why there was no comment on the perf after the fact.</p>



<a name="224112882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224112882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224112882">(Jan 26 2021 at 22:17)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Unfortunately I couldn't make it too far. I got through 3 of the regressions but that's it. I can push what I have if you want to finish today. otherwise I can finish tomorrow</p>



<a name="224112907"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224112907" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224112907">(Jan 26 2021 at 22:17)</a>:</h4>
<p>I'll try to take a look, thanks!</p>



<a name="224113108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224113108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224113108">(Jan 26 2021 at 22:19)</a>:</h4>
<p><a href="https://github.com/rust-lang/rustc-perf/pull/831">https://github.com/rust-lang/rustc-perf/pull/831</a></p>



<a name="224115797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224115797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224115797">(Jan 26 2021 at 22:44)</a>:</h4>
<p>how do tests like <a href="https://github.com/rust-lang/rust/issues/81207">#81207</a> work? it's not clear to me what it is comparing as before and after</p>



<a name="224116021"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116021" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116021">(Jan 26 2021 at 22:46)</a>:</h4>
<p>it's buggy - see <a href="https://github.com/rust-lang/rustc-perf/issues/832">https://github.com/rust-lang/rustc-perf/issues/832</a> -- the idea is to generate a revert to master before the rollup merged and then see what re-landing the rollup would do. but the generated links on PR are not quite right, as they're from current master, so you get definitely the wrong idea</p>



<a name="224116035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116035">(Jan 26 2021 at 22:47)</a>:</h4>
<p>the feature needs more work</p>



<a name="224116126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116126">(Jan 26 2021 at 22:47)</a>:</h4>
<p>can't you just test a plain revert and compare it in reverse?</p>



<a name="224116248"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116248" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116248">(Jan 26 2021 at 22:48)</a>:</h4>
<p>I think no, because things on master may have changed since then</p>



<a name="224116274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116274">(Jan 26 2021 at 22:49)</a>:</h4>
<p>and the revert may not even be possible</p>



<a name="224116294"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116294" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116294">(Jan 26 2021 at 22:49)</a>:</h4>
<p>i.e., without rebasing it</p>



<a name="224116312"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116312" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116312">(Jan 26 2021 at 22:49)</a>:</h4>
<p>yeah ok, I'm assuming the simple case for a revert</p>



<a name="224116351"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116351" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116351">(Jan 26 2021 at 22:50)</a>:</h4>
<p>I think fixing the feature would not actually require too much work, just needs someone to sit down with it for an hour or so. Maybe I can find time this week, I'll make a note.</p>



<a name="224116471"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116471" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116471">(Jan 26 2021 at 22:51)</a>:</h4>
<p>more directly to the PR history, I guess we'd want a <code>@bors try</code> to a specific merge base, rather than master</p>



<a name="224116603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116603">(Jan 26 2021 at 22:52)</a>:</h4>
<p>sure, we could do things that way. the revert commit which is first in the PR essentially accomplishes that.</p>



<a name="224116623"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116623" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116623">(Jan 26 2021 at 22:52)</a>:</h4>
<p>(albeit with a race condition)</p>



<a name="224116723"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224116723" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224116723">(Jan 26 2021 at 22:53)</a>:</h4>
<p>could make a dedicated <code>perf</code> branch for this purpose -- reset to a base, open a retargeted PR, then try and perf</p>



<a name="224117173"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224117173" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224117173">(Jan 26 2021 at 22:58)</a>:</h4>
<p>yes, there's actually support now from an infra perspective, but I haven't had the time to rework rust-timer to use it. It needs some work to queue the commits up and handle the webhooks right, so not precisely trivial. I think getting the revert commits right is probably easier.</p>



<a name="224117226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224117226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224117226">(Jan 26 2021 at 22:58)</a>:</h4>
<p>I've looked through the other things in the report and finished it up and merged <span class="user-mention" data-user-id="224872">@rylev</span>, will go open a TWIR PR now</p>



<a name="224117378"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224117378" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224117378">(Jan 26 2021 at 23:00)</a>:</h4>
<p>done</p>



<a name="224117809"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2001%2026/near/224117809" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2001.2026.html#224117809">(Jan 26 2021 at 23:04)</a>:</h4>
<p>Thanks!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>